Make forgetting setup_aruba a hard failure #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,7 +90,7 @@ Feature: Getting started with RSpec and aruba | |||
|
|
|||
| Running `setup_aruba` removes `tmp/aruba`, creates a new one `tmp/aruba` | |||
| and make it the working directory. Running it within a `before(:all)`-hook, | |||
| run some `aruba`-method and then run `setup_arub` again within a | |||
| run some `aruba`-method and then run `setup_aruba` again within a | |||
There was a problem hiding this comment.
Could we change this text to drop the hyphens, so that
`aruba`-method
becomes
`aruba` method
lib/aruba/api/core.rb
Outdated
| @@ -127,7 +127,7 @@ def expand_path(file_name, dir_string = nil) | |||
| fail ArgumentError, message unless file_name.is_a?(String) && !file_name.empty? | |||
|
|
|||
| # rubocop:disable Metrics/LineLength | |||
| aruba.logger.warn %(`aruba`'s working directory does not exist. Maybe you forgot to run `setup_aruba` before using it's API. This warning will be an error from 1.0.0) unless Aruba.platform.directory? File.join(aruba.config.root_directory, aruba.config.working_directory) | |||
| fail %(Aruba's working directory does not exist. Maybe you forgot to run `setup_aruba` before using it's API.) unless Aruba.platform.directory? File.join(aruba.config.root_directory, aruba.config.working_directory) | |||
There was a problem hiding this comment.
Grammar note: it's => its
|
This is a huge help! |
|
I'm going to see about moving the setup check to earlier in the process, so it doesn't depend on |
olleolleolle
approved these changes
Nov 10, 2017
I might do that later, it breaks a lot right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make forgetting
setup_arubaa hard failureDetails
Forgetting to run
setup_arubaresulted in a warning announcing that it would be a hard failure in 1.0.0. Kind of like 'deprecated', but with a twist. This PR makes the hard failure happen.Motivation and Context
Part of getting ready for 1.0.0.
How Has This Been Tested?
Scenarios that relied on the old behavior have been removed. The hard failure is not tested explicitly.
Types of changes
Checklist: