Remove more deprecated features #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2017
Closed
- Require options of #run_command and #run_command_and_stop to be passed as a hash. - Remove Aruba.process - Remove 'before :cmd' hook
mvz
force-pushed
the
remove-more-deprecated-features
branch
from
963abef
to
1ee9a51
Compare
|
Ready for review. |
olleolleolle
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove remaining deprecated bits in preparation of the 1.0.0 release.
Details
This removes
@deprecated(deprecated)and the functionality they testI have kept one deprecated scenario; the one for setting the home directory to 'some other path'. It is related to #478 and it is not clear to me what Aruba 1.0.0 will and will not support here.
Motivation and Context
A major version bump is the right time to remove deprecated items.
Types of changes
Checklist: