Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix final OSX build failures #497

Merged
merged 6 commits into from
Sep 16, 2017
Merged

Fix final OSX build failures #497

merged 6 commits into from
Sep 16, 2017

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Sep 8, 2017 •
edited
Loading

Summary

This fixes/skips the cucumber scenarios failing on OSX.

Details

The following bits need fixing:

  • $HOME is not in /home on OSX, so features that assume that need updating
  • Readline doesn't seem to be available on OSX for CRuby versions 1.9.3 and 2.0.0.
  • Anything else that may turn up :-)

I have trimmed .travis.yml to be nice to Travis while this is still WIP. I'll remove that commit at the end.

Motivation and Context

Making master green ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@mvz
Copy link
Contributor Author

mvz commented Sep 8, 2017

Travis seems to be thoroughly confused ...

@mvz mvz force-pushed the fix/final-osx-build-failures branch from cfe267d to 7982819 Compare September 8, 2017 07:26
@mvz
Copy link
Contributor Author

mvz commented Sep 9, 2017

Travis is experiencing a major outage of OSX builds right now. I guess we'll have to wait ...

@mvz mvz changed the title [WIP] Fix final OSX build failures Fix final OSX build failures Sep 11, 2017
@mvz mvz requested a review from maxmeyer September 11, 2017 04:43
@maxmeyer
Copy link
Member

Why did you leave require readline as hook? Are there any places left where it makes sense? does this hook cause failures on Mac OS X?

@mvz
Copy link
Contributor Author

mvz commented Sep 11, 2017

The scenarios marked with the @requires-readline hook need readline to work (because pry needs it). Apparently readline is not installed properly for older Rubies in Travis' OSX images (I don't know about real world OSX installations).

@mvz
Copy link
Contributor Author

mvz commented Sep 11, 2017

(An alternative is to drop pry as a build dependency and just test with irb. That would need an update to bin/console too.)

@maxmeyer
Copy link
Member

@mvz I think it make sense to use a minimal approach an use IRB instead of pry although it doesn't have all the convenient features.

maxmeyer
maxmeyer requested changes Sep 14, 2017
View reviewed changes
Copy link
Member

@maxmeyer maxmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove pry from the build. Better no build errors and less problems.

@mvz mvz force-pushed the fix/final-osx-build-failures branch from f5083a3 to 7a0719a Compare September 14, 2017 13:34
@maxmeyer
Copy link
Member

maxmeyer commented Sep 15, 2017 •
edited
Loading

@mvz There are still failures on Mac OS X with 1.9.3 and 2.0.0. Do you own a mac to have a look for those? But at least they don't look like major problems (show stoppers) for mergin this PR.

@mvz
Copy link
Contributor Author

mvz commented Sep 15, 2017

No, I don't. This is unfortunately very hard to debug.

@cucumber cucumber deleted a comment from mvz Sep 15, 2017
@mvz
Copy link
Contributor Author

mvz commented Sep 16, 2017

The OSX builds are green now.

@maxmeyer maxmeyer merged commit 7aa51fc into master Sep 16, 2017
@mvz mvz deleted the fix/final-osx-build-failures branch September 16, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmeyer maxmeyer maxmeyer approved these changes

Assignees
No one assigned
Labels
status: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @maxmeyer