Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG update for cucumber/cucumber #251 #482

Merged
merged 3 commits into from
Aug 23, 2017
Merged

CHANGELOG update for cucumber/cucumber #251 #482

merged 3 commits into from
Aug 23, 2017

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Aug 23, 2017

Summary

Lots of changes in accordance with cucumber/cucumber 251

Motivation and Context

Working to normalize documents across the various repos.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of code base without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mxygem
Copy link
Member Author

mxygem commented Aug 23, 2017

Documentation only changes, does not impact code-base so test success/failure is not indicative of my changes. Merging!

@mxygem mxygem merged commit 3f3e4f6 into master Aug 23, 2017
@mxygem mxygem deleted the changelog-work branch August 23, 2017 18:28
@mxygem mxygem restored the changelog-work branch August 24, 2017 06:06
@mxygem
Copy link
Member Author

mxygem commented Aug 24, 2017

Hey! So, as a heads up, I got a bit eager in making some doc updates and moved forward without being fully aware of various processes. With that said, if my merging and deleting branches too soon has caused issues and you'd like me to fix or flat out revert this PR, happy to do so as I definitely don't want to cause issues/step on toes. If you have a preferred fix method you'd like me to run, please send it my way.

Thanks and sorry if this has caused any troubles!

Check out the #committers channel in Slack for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant