Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs to use our fixtures #460

Merged
merged 1 commit into from
Jul 23, 2017

Conversation

maxmeyer
Copy link
Member

Summary

This PR improves the documentation about using our fixtures API.

Details

  • Fix false positive feature tests - they creating the wrong file and succeed although they should have failed
  • Add example about how to use fixtures along with commands

Motivation and Context

I've got an ongoing valuable discussion with @remy about the usage of fixtures. It turned out, that our docs are wrong at some places and additionally a good example was missing to clarify the use of fixtures with commands.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase withouth changing any existing functionality)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@maxmeyer maxmeyer merged commit aa0f8d1 into master Jul 23, 2017
@aslakhellesoy
Copy link
Contributor

Hi @maxmeyer,
Thanks for your contribution and welcome to the committers team!
You can now push directly to this repo and all other repos under the cucumber
organization. Please read up on the general contrinuting guidelines to learn more.

Cheers,
Aslak Hellesøy
Creator of Cucumber

@maxmeyer maxmeyer added this to the 1.0.0-alpha.3 milestone Jul 26, 2017
@mvz mvz deleted the feature/improve-docs-on-usage-of-fixtures branch November 7, 2017 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants