Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement existentially quantified parameters #302

Merged
merged 22 commits into from
Sep 5, 2023
Merged

Conversation

rachitnigam
Copy link
Member

Fixes #121.

@rachitnigam
Copy link
Member Author

Okay, basic parsing and astconv conversion is working. Next step is to separate the components into assume and assert. Previously, all component constraints were asserted into the calling component by now some of them should be assumed. This is because constraints over existentially quantified parameters are supplied by instances instead of being proven by the caller.

After that, we need to figure out what to do with monomorphization. For now, maybe I'll require that all existential parameters have defined values in the program and eventually remove that constraint in a future PR when we want to be able to do retiming.

@rachitnigam rachitnigam marked this pull request as ready for review September 2, 2023 14:50
@rachitnigam
Copy link
Member Author

Okay, this PR now implements a basic AST to IR lowering for existential types. Monomorphization crashes when it sees existential parameters. A followup PR will build the flow that allows compilation of programs with existential types.

@rachitnigam
Copy link
Member Author

This should probably not be reviewed till #304 and #305 are merged. Currently, the diff on this is pretty big because it includes those changes.

@rachitnigam
Copy link
Member Author

Okay, this is ready to review now!

@rachitnigam rachitnigam linked an issue Sep 3, 2023 that may be closed by this pull request
Base automatically changed from ir-dev to main September 4, 2023 17:12
@rachitnigam rachitnigam merged commit 645978d into main Sep 5, 2023
2 checks passed
@rachitnigam rachitnigam deleted the exists-param branch September 5, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existentially quantified parameters
1 participant