Spreading on write with use_blob & use_ti #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CellPutProportionalSpread in TI process is used in case allow_spread=True is specified and one of the elements in the write. Meaning all values will be spread. Sample test script on PR.
CellPutProportionalSpread in TI process is used in case allow_spread=True is specified and one of the elements in the write. Meaning all values will be spread. Sample test script on PR.
Simplification was oversimplified and wrong. Sequence is important in the statement. Alternate formulation would be:
if (cube_name.lower().startswith("}elementattributes_") or not increment) "CellPutN" else "CellIncrementN"
But that's less readable than current.
Kevin-Dekker
changed the title
MariusWirtz
reviewed
Apr 21, 2023
Collaborator
|
Nice work @Kevin-Dekker Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A concept to allow simple proportional spreads in case any of the elements (coordinates) is c level and the value to write is numerical when using use_ti or use_blob.
Usage
Specify allow_spread=True and write to one or more c level elements.
Tests
Scripts included in tm1py/Tests, further tests required.
Limitations