Fix execute_mdx() with top = n with n < number of dims in the cube #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the positioning of $top and $skip in the Axis to apply to tuples in the function extract_cellset_raw_response()
Utils.py
Fix the cell_ordinal in the function build_content_from_cellset_dict() to match the axis ordinals.
issue/fix-cell-write-top-skip
MariusWirtz
reviewed
Mar 28, 2023
|
|
||
| content_as_dict = CaseAndSpaceInsensitiveTuplesDict() | ||
| for cell_ordinal, cell in enumerate(cells[:top or len(cells)]): | ||
| # if skip is used in execution we must use the original ordinal from the cell, if not we can simply enumerate |
Collaborator
There was a problem hiding this comment.
I don't think you can simply skip this logic.
To verify if you change breaks anything, you can install pytests (pip install pytests) and run the tests in CellService_test.py
Collaborator
|
@cwffonseca two things.
|
Collaborator
|
solved with #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using execute_mdx() with top=n with n smaller than the number of dimensions in the cube, the result showed only the first n columns (coordinates) instead of all columns and only n rows. This pull request fixes this issue, and also improves the performance a bit by using skip in the Axis query as well, which leads to a smaller response.