Skip to content

Fix handling of ] in element names in execute_mdx #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MariusWirtz merged 1 commit into from
Jan 5, 2023
Merged

Fix handling of ] in element names in execute_mdx #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TM1py/Utils/Utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def hierarchy_name_from_element_unique_name(element_unique_name: str) -> str:


def element_name_from_element_unique_name(element_unique_name: str) -> str:
return element_unique_name[element_unique_name.rfind('].[') + 3:-1]
return element_unique_name[element_unique_name.rfind('].[') + 3:-1].replace("]]", "]")


def element_names_from_element_unique_names(element_unique_names: Iterable[str]) -> Tuple[str]:
Expand Down
14 changes: 9 additions & 5 deletions Tests/Utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,18 +391,22 @@ def test_frame_to_significant_digits_too_many_digits(self):
framed_value = frame_to_significant_digits(1234, 2)
self.assertEqual('1200', framed_value)

def test_frame_to_significant_digits_too_many_digits(self):
framed_value = frame_to_significant_digits(1234, 2)
self.assertEqual('1200', framed_value)

def test_frame_to_significant_digits_scientific_too_many_digits(self):
framed_value = frame_to_significant_digits(1.2345E-1, 2)
self.assertEqual('0.12', framed_value)

def test_frame_to_significant_digits_scientific_too_many_digits(self):
def test_frame_to_significant_digits_scientific_too_many_digits_large(self):
framed_value = frame_to_significant_digits(1.2345E3, 2)
self.assertEqual('1200.0', framed_value)

def test_element_name_from_element_unique_name_happy_case(self):
element_name = Utils.element_name_from_element_unique_name("[d1].[e1]")
self.assertEqual("e1", element_name)

def test_element_name_from_element_unique_name_with_double_closing_square_bracket(self):
element_name = Utils.element_name_from_element_unique_name("[d1].[other [please specify]]]")
self.assertEqual("other [please specify]", element_name)

@classmethod
def tearDownClass(cls):
cls.tm1.logout()
Expand Down