adding lamda expression to filter tuple

[ldelberg]

It's possible to filter the transactionlog entries with a lambda expression: Tuple/any(t: t eq 'filter value')
The function get_transaction_log_entries accepts kwargs so we could add a section to the log_filter list in order to generate a lambda expression for the query:
get_transaction_log_entries(reverse=True, user='Admin', cube='plan_BudgetPlan', tuple={'105': 'eq', '405': 'eq', '41101': 'ge'})

tuple is a dict with 'filter value' as key and a operator as value.

This could be extended to a lambda all expression by defining a lambda_method parameter which defaults to "any" but can changed to "all".
What do you think?

[zsoltmoravcsik]

That is a great idea. +1

…

On Wed, 16 Nov 2022 at 11:20, ldelberg ***@***.***> wrote: It's possible to filter the transactionlog entries with a lambda expression: Tuple/any(t: t eq 'filter value') The function get_transaction_log_entries accepts kwargs so we could add a section to the log_filter list in order to generate a lambda expression for the query: get_transaction_log_entries(reverse=True, user='Admin', cube='plan_BudgetPlan', tuple={'105': 'eq', '405': 'eq', '41101': 'ge'}) tuple is a dict with 'filter value' as key and a operator as value. This could be extended to a lambda all expression by defining a lambda_method parameter which defaults to "any" but can changed to "all". What do you think? ------------------------------ You can view, comment on, or merge this pull request online at: #831 Commit Summary - 308dc21 <308dc21> adding lamda expression to filter tuple File Changes (1 file <https://github.com/cubewise-code/tm1py/pull/831/files>) - *M* TM1py/Services/ServerService.py <https://github.com/cubewise-code/tm1py/pull/831/files#diff-34bba3918e81eead6084c8dd8ba01f378382f2a1833e38a4f712189d9801d948> (83) Patch Links: - https://github.com/cubewise-code/tm1py/pull/831.patch - https://github.com/cubewise-code/tm1py/pull/831.diff — Reply to this email directly, view it on GitHub <#831>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHNEK3B73HYVXCHEJI77MY3WISYQNANCNFSM6AAAAAASCBU3C4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[MariusWirtz]

Nice work @ldelberg! Thanks

I added a suggestion regarding naming and parametrization.

If you have time you can also add a test case here:

tm1py/Tests/ServerService_test.py

Line 151 in 2d45a62

def test_get_last_transaction_log_entries(self):

Otherwise, I would write a test as part of a review next week or so.

[MariusWirtz]

@adscheevel adding you to this conversation since you wrote the previous version of this function.
I'm curious about your thoughts on the feature.

[ldelberg]

@MariusWirtz I've added a test for this part of the function. Please check if it meets your expectations