add pyproject.toml / update gitignore #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrambldchannel
changed the title
Contributor
Author
|
Actually, you might need to add a version to the top level init.py, will check at some point |
Collaborator
|
Thanks @scrambldchannel and @zallin93 for reporting and fixing this issue. I will merge and take take a look at |
Collaborator
|
This is now released to PyPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #824 by adding a simple
pyproject.tomlthat hands over to setup tools.This is a sort of quick fix rather than migrating to a pure
pyproject.tomlapproach.Also adds a couple of lines to gitignore to exclude build artifacts. Maybe you might consider just using something like https://github.com/github/gitignore/blob/main/Python.gitignore ?