Chore search methods #663
Merged
Chore search methods #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by process name and parameter value
MariusWirtz
reviewed
Jan 11, 2022
MariusWirtz
reviewed
Jan 11, 2022
MariusWirtz
reviewed
Jan 11, 2022
Removed logic for matching_tasks_only parameter of the search functions. All chore tasks for matching chores will be returned now
added additional tests to search methods to check length of returned chore_names and returned names for each item returned
Moved search tests above tests that modify/mutate the tasks on chores since test parameters were derived from the initial chore definition
Collaborator
|
Nice one @adscheevel Thanks! |
MariusWirtz
added a commit
that referenced
this pull request
Jan 12, 2022
- cater for numeric parameter values - add readme for tests - fix all chore tests successor of #663
MariusWirtz
added a commit
that referenced
this pull request
Jan 13, 2022
- cater for numeric parameter values - add readme for tests - fix all chore tests successor of #663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two functions for searching for chores based on process name or defined parameter value(not parameter name and not the parameter default set in the TI process) in the chore configuration. I took a stab at some test cases as well.