Skip to content

Conversation

@MariusWirtz
Copy link
Collaborator

@MariusWirtz MariusWirtz commented Nov 22, 2021

related to #604

This draft pull request attempts to resolve the current limitation of the iterative_json_parsing argument, that it can't be used in conjunction with include_attributes on the execute_mdx_dataframe function.

@MariusWirtz MariusWirtz changed the title wip Allow iterative_json_parsing in conjunction with include_attributes Nov 29, 2021
@MariusWirtz MariusWirtz changed the title Allow iterative_json_parsing in conjunction with include_attributes wip: Allow iterative_json_parsing in conjunction with include_attributes Nov 29, 2021
@MariusWirtz MariusWirtz force-pushed the wip/iterative-json-and-include-attributes branch from ad94302 to 310ac12 Compare January 2, 2022 21:11
Build proper header line during ijson parsing
@MariusWirtz MariusWirtz force-pushed the wip/iterative-json-and-include-attributes branch from 310ac12 to 748e99a Compare January 2, 2022 21:18
@MariusWirtz MariusWirtz marked this pull request as ready for review January 2, 2022 21:35
@MariusWirtz MariusWirtz changed the title wip: Allow iterative_json_parsing in conjunction with include_attributes Allow iterative_json_parsing in conjunction with include_attributes Jan 2, 2022
@MariusWirtz
Copy link
Collaborator Author

Hi @rclapp,

regarding your comment from November #612 (comment) please feel free to test this feature or approve it.

I think it's done.

@MariusWirtz MariusWirtz merged commit 4b0997d into master Jan 17, 2022
@MariusWirtz MariusWirtz deleted the wip/iterative-json-and-include-attributes branch April 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants