Fix failing tests for v12 #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MariusWirtz
commented
Oct 18, 2025
MariusWirtz
commented
- adapt function to changing JSON response on edges
- adapt test to changing error message in compile process response
- fix tests for search_string_in_code function
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix failing tests and adapt code to TM1 v12 changes, particularly in JSON response structure and compile error messages.
- Update ElementService to handle v12 edge JSON shape.
- Adjust tests to match updated compile error message token.
- Update process procedure test strings for clarity.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/ProcessService_test.py | Aligns expected error message token and updates procedure strings used in tests. |
| TM1py/Services/ElementService.py | Adds version-aware parsing of consolidation edges for TM1 v12 JSON structure. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- adapt function to changing JSON response on edges - adapt test to changing error message in compile process response - fix tests for search_string_in_code function
MariusWirtz
force-pushed
the
fix-tests-for-v12
branch
from
e7408fb to
aacda27
Compare
Contributor
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.