Fix sandboxing_disabled property of RestService #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the sandboxing_disabled property in the RestService class to properly retrieve the TM1 configuration value and corrects a test assertion that was checking for an incorrect error message.
- Updated REST API call to use proper JSON response parsing instead of direct value extraction
- Fixed test assertion to check for the correct error message content
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TM1py/Services/RestService.py | Modified sandboxing_disabled property to use correct API endpoint and JSON parsing |
| Tests/CellService_test.py | Updated test assertion to match actual error message format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Consider actual TM1 config value for DisableSandboxing Fix unrelated assertion issue in test_clear_with_mdx_invalid_query Fixes #1285
MariusWirtz
force-pushed
the
1285-fix-disable-sandboxing-check
branch
from
762d78f to
a2e4ce0
Compare
Contributor
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the actual TM1 config value for DisableSandboxing
Fix unrelated assertion issue in test_clear_with_mdx_invalid_query
Fixes #1285