Skip to content

Conversation

@bdunleavy22
Copy link
Contributor

Refined branch based on #1270.

Added function update_static_elements and modified update for static subsets

@MariusWirtz MariusWirtz requested a review from Copilot September 10, 2025 14:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the SubsetService.py to improve handling of static subset element updates by introducing a new update_static_elements function and modifying the existing update method to use it.

  • Added a new update_static_elements function that provides a more flexible way to update elements in static subsets
  • Modified the update method to use the new function for static subsets instead of directly deleting and recreating elements
  • Enhanced the get_element_names function to accept both string subset names and Subset objects with improved documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MariusWirtz MariusWirtz merged commit 4885702 into cubewise-code:master Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants