Fixing #1126 and#1128 - timeout is an explicit parameter hence kwargs(timeout) does not work, adding request_async_id in execute_process_with_return

[ivankulman]

1126:
Timeout is a parameter in the request function, therefore the kwargs.get('timeout', self._timeout) would never get the specified value.

Also for consistency adding the timeout parser to default it to the class._timeout value if not provided.

1128:
Adding the return_async_id to the execute_process_with_return so that it has the same functionality and signature as the execute_with_return

linkages for github:
this fixes #1126 and adds #1128 as well.

[ivankulman]

@MariusWirtz please review.

[MariusWirtz]

Looking good! Thanks for the fix.

It would be nice to have a test case to verify that

• timeout works on unbound processes (should be easy to test with sleep ti function)
  - return_async_id indeed returns the async_id on processes and unbound processes

Currently, we don't have tests on either. That's probably how we missed the bug.

https://github.com/cubewise-code/tm1py/blob/master/Tests/ProcessService_test.py

[ivankulman]

tests added

[MariusWirtz]

Nice work. Thank you!

[ivankulman]

@MariusWirtz would you mind releasing this as 2.0.4? :)
We need these changes available in pypi for our internal repos.

[MariusWirtz]

I just found a minor issue.
When running all tests in the ProcessService_test class, the test_execute_process_with_return_returns_timeout fails.
Can you reproduce it?

As soon as this is resolved, I can do the 2.0.4 release

[ivankulman]

Hi Marius,
Looks like the test case is using the pre-change version of the code and tries to JSONify the async id instead of just:
if return_async_id: return response

Just FYI, I am testing this against TM1 version: 11.8.02200.2

And here's my test output with successful tests:

[MariusWirtz]

Found it! #1130

Perhaps in your env, it wasn't reproducible because async_requests_mode is True in your config.ini?

I will merge and do a release.

[MariusWirtz]

2.0.4 is available on pypi.
https://pypi.org/project/TM1py/2.0.4/

[ivankulman]

Yes I had
async_requests_mode=True
In my config file.

Thanks for releasing to pypi!

Ivan