Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-compiler): Fix doubled calls to convertTz() for compound time dimensions with custom granularities #9369

Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(schema-compiler): Fix doubled calls to convertTz() for compound time dimensions with custom granularities #9369

merged 1 commit into from
Mar 21, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Mar 20, 2025 •
edited
Loading

This fixes incorrect SQL generation for compound time dimensions with custom granularities.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon marked this pull request as ready for review March 20, 2025 13:15
@KSDaemon KSDaemon requested a review from a team as a code owner March 20, 2025 13:15
@KSDaemon KSDaemon merged commit 0dc8320 into master Mar 21, 2025
55 checks passed
@KSDaemon KSDaemon deleted the fix/remove-double-convert-tz branch March 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovr ovr ovr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSDaemon @ovr