Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Functions without arguments alias as plain function name #9338

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes an issue with functions being aliased as the expression when no alias is specified. For instance, the query SELECT version() would name the resulting column version() instead of version like PostgreSQL does. Related tests are adjusted.

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested review from a team as code owners March 12, 2025 16:46
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (dc5dec9) to head (47c78b6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9338   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         229      229           
  Lines       82696    82696           
=======================================
  Hits        69267    69267           
  Misses      13429    13429           
Flag Coverage Δ
cubesql 83.76% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit de10c23 into master Mar 13, 2025
72 checks passed
@MazterQyou MazterQyou deleted the cubesql/func-alias-no-arg branch March 13, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants