feat: Implement disable_post_processing in /v1/sql #9331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9331 +/- ##
==========================================
- Coverage 83.76% 83.73% -0.03%
==========================================
Files 229 229
Lines 82697 82538 -159
==========================================
- Hits 69268 69117 -151
+ Misses 13429 13421 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcheshkov
force-pushed
the
disable-postprocessing-in-sql-endpoint
branch
from
13d8185 to
02c0bab
Compare
MazterQyou
approved these changes
Mar 12, 2025
KSDaemon
approved these changes
Mar 12, 2025
| @@ -330,6 +330,7 @@ class ApiGateway { | |||
| if (req.query.format === 'sql') { | |||
| await this.sql4sql({ | |||
| query: req.query.query, | |||
| disablePostProcessing: req.query.disable_post_processing === 'true', | |||
There was a problem hiding this comment.
I see that we have disable_post_processing in snake-case defined in the docs... But in other places we have CamelCase.... Maybe we can review and align it?
There was a problem hiding this comment.
+1 for camelCase.
I assume we need to follow the style we used previously, and it should be camelCase.
cC @igorlukanin
ovr
approved these changes
Mar 12, 2025
mcheshkov
force-pushed
the
disable-postprocessing-in-sql-endpoint
branch
from
ee598bb to
a39ba8a
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Second part of #9301