Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch isVisible when applying member level access policies #8921

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

bsod90
Copy link
Member

@bsod90 bsod90 commented Nov 6, 2024

playground

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested a review from a team as a code owner November 6, 2024 21:54
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 1:24am

@bsod90 bsod90 requested a review from paveltiunov November 6, 2024 21:54
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 6, 2024
@bsod90 bsod90 force-pushed the fix_rbac_playground_visibility branch 2 times, most recently from 4309cdc to d5bcb36 Compare November 6, 2024 23:37
@bsod90 bsod90 changed the title fix: ignore Data Access Policy-defined visibility in dev-mode and fix: patch isVisible when applying member level access policies Nov 6, 2024
@bsod90 bsod90 force-pushed the fix_rbac_playground_visibility branch from d5bcb36 to 0fa3616 Compare November 8, 2024 01:24
@bsod90 bsod90 merged commit 2bb1d21 into master Nov 8, 2024
57 checks passed
@bsod90 bsod90 deleted the fix_rbac_playground_visibility branch November 8, 2024 01:46
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
…-js#8921)

* fix: ignore Data Access Policy-defined visibility in dev-mode and
playground

* fix: patch isVisible when applying member level policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants