Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 11, 2024

This PR updates the findPreAggregationForQuery() logic to try to choose the preaggregation with the exact same granularity from the potentially applicable list. This especially makes sense when using custom granularity in the query and if there is a related preAggregation.

Related to:

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested review from a team as code owners September 11, 2024 15:39
@vercel
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 3:35pm

@KSDaemon KSDaemon changed the base branch from master to feat/date_bin_cubestorequery September 11, 2024 15:40
@KSDaemon KSDaemon marked this pull request as draft September 12, 2024 07:58
@KSDaemon KSDaemon marked this pull request as draft September 12, 2024 07:58
@KSDaemon KSDaemon force-pushed the feat/date_bin_cubestorequery branch from 0ae1b29 to 85417d9 Compare September 12, 2024 13:36
@KSDaemon KSDaemon force-pushed the feat/date_bin_cubestorequery branch from 85417d9 to 9f52bf7 Compare September 12, 2024 15:15
@KSDaemon KSDaemon force-pushed the feat/date_bin_cubestorequery branch from 9f52bf7 to 13ebe9b Compare September 12, 2024 15:20
@KSDaemon KSDaemon force-pushed the feat/findPreAggregationForQuery-improve branch from 270ee0c to b4d9004 Compare September 12, 2024 15:34
@KSDaemon KSDaemon force-pushed the feat/date_bin_cubestorequery branch 2 times, most recently from 8cdba10 to f8c2d25 Compare September 13, 2024 08:51
Base automatically changed from feat/date_bin_cubestorequery to master September 13, 2024 09:28
@KSDaemon KSDaemon closed this Oct 21, 2024
@KSDaemon KSDaemon deleted the feat/findPreAggregationForQuery-improve branch October 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants