feat(backend-native): Add forceContinueWait parameter to /cubesql API endpoint#10385
Draft
MazterQyou wants to merge 1 commit intomasterfrom
Draft
feat(backend-native): Add forceContinueWait parameter to /cubesql API endpoint#10385MazterQyou wants to merge 1 commit intomasterfrom
forceContinueWait parameter to /cubesql API endpoint#10385MazterQyou wants to merge 1 commit intomasterfrom
Conversation
a98b59e to
e8b28db
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10385 +/- ##
===========================================
+ Coverage 57.49% 78.43% +20.94%
===========================================
Files 222 472 +250
Lines 17334 92031 +74697
Branches 3544 3544
===========================================
+ Hits 9966 72188 +62222
- Misses 6831 19306 +12475
Partials 537 537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e8b28db to
50ee13d
Compare
Contributor
|
I actually just filed this #10387 - funny timing! Thanks for working on this. |
… API endpoint Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
50ee13d to
98213dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds
forceContinueWaitoptional boolean parameter to/cubesqlAPI endpoint which, when enabled, surfacesContinue waiterrors over HTTP transport instead of looping and holding the connection indefinitely.