feat(cubesql): Support more directions for FETCH statement#10377
Merged
Conversation
…ants Previously, only `FETCH <count>` was supported. This adds handling for: - FETCH NEXT (returns 1 row) - FETCH FORWARD [count] (returns count rows, or 1 if omitted) - FETCH ALL / FETCH FORWARD ALL (returns all remaining rows)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #10377 +/- ##
==========================================
- Coverage 83.29% 78.44% -4.85%
==========================================
Files 248 471 +223
Lines 74486 91801 +17315
Branches 0 3539 +3539
==========================================
+ Hits 62041 72012 +9971
- Misses 12445 19252 +6807
- Partials 0 537 +537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only
FETCH <count>was supported. This adds handling for:refs #10320