Skip to content

feat(cubesql): Support more directions for FETCH statement#10377

Merged
ovr merged 3 commits intomasterfrom
feat/cubesql-fetch-forward-support
Feb 9, 2026
Merged

feat(cubesql): Support more directions for FETCH statement#10377
ovr merged 3 commits intomasterfrom
feat/cubesql-fetch-forward-support

Conversation

@ovr
Copy link
Member

@ovr ovr commented Feb 6, 2026

Previously, only FETCH <count> was supported. This adds handling for:

  • FETCH NEXT (returns 1 row)
  • FETCH FORWARD [count] (returns count rows, or 1 if omitted)
  • FETCH ALL / FETCH FORWARD ALL (returns all remaining rows)

refs #10320

ovr added 2 commits February 6, 2026 19:34
…ants

Previously, only `FETCH <count>` was supported. This adds handling for:
- FETCH NEXT (returns 1 row)
- FETCH FORWARD [count] (returns count rows, or 1 if omitted)
- FETCH ALL / FETCH FORWARD ALL (returns all remaining rows)
@ovr ovr requested a review from a team as a code owner February 6, 2026 22:30
@github-actions github-actions bot added the rust Pull requests that update Rust code label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 41.61074% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.44%. Comparing base (85d9e79) to head (103add9).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/sql/postgres/error.rs 44.33% 59 Missing ⚠️
...st/cubesql/cubesql/src/sql/postgres/ast_helpers.rs 28.57% 25 Missing ⚠️
rust/cubesql/cubesql/src/sql/postgres/shim.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10377      +/-   ##
==========================================
- Coverage   83.29%   78.44%   -4.85%     
==========================================
  Files         248      471     +223     
  Lines       74486    91801   +17315     
  Branches        0     3539    +3539     
==========================================
+ Hits        62041    72012    +9971     
- Misses      12445    19252    +6807     
- Partials        0      537     +537     
Flag Coverage Δ
cube-backend 57.60% <ø> (?)
cubesql 83.28% <41.61%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr merged commit 7cbafd5 into master Feb 9, 2026
79 of 86 checks passed
@ovr ovr deleted the feat/cubesql-fetch-forward-support branch February 9, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant