fix(tasty): garbage collection in injector#1002
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d1cc141 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-25d66c2. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core CSS rule insertion/deletion bookkeeping used by the runtime style injector; mistakes could still cause missing or misapplied styles during cleanup, though coverage is improved with new regression tests.
Overview
Fixes an injector GC bug where deleting multiple rules at non-contiguous indices could corrupt the stored rule indices and make remaining styles disappear.
SheetManagernow always tracks exact inserted rule indices, returnsnullwhen nothing was inserted, and adjusts remainingRuleInfo/keyframes indices using the actual deleted index set (not just a contiguous range).StyleInjector.property()now only records a custom@propertyas injected when the global rule insertion succeeds.Adds regression tests covering non-contiguous deletions and multi-index rules to ensure indices and
ruleCountstay consistent.Written by Cursor Bugbot for commit d1cc141. This will update automatically on new commits. Configure here.