Skip to content

refactor: Removed MetadataCacheFactory::build_writer_props #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2024
Merged

refactor: Removed MetadataCacheFactory::build_writer_props #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions datafusion/src/physical_plan/parquet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ use arrow::{
};
use hashbrown::HashMap;
use log::debug;
use parquet::file::properties::{WriterProperties, WriterPropertiesBuilder};
use parquet::file::{
footer,
metadata::RowGroupMetaData,
Expand Down Expand Up @@ -141,7 +140,6 @@ pub trait ParquetMetadataCache: Debug + Sync + Send {
}
}

// TODO: Rename to ParquetMetadataCacheFactory? Rename for build_writer_props field?
/// Constructs the desired types of caches for Parquet Metadata.
pub trait MetadataCacheFactory: Sync + Send {
/// Makes a noop cache (which doesn't cache)
Expand All @@ -152,13 +150,6 @@ pub trait MetadataCacheFactory: Sync + Send {
max_capacity: u64,
time_to_idle: Duration,
) -> Arc<dyn ParquetMetadataCache>;
/// Modifies and builds writer properties.
fn build_writer_props(
&self,
builder: WriterPropertiesBuilder,
) -> Result<WriterProperties> {
Ok(builder.build())
}
}

/// Default MetadataCache, does not cache anything
Expand Down
Loading