Skip to content

feat: Support planning LOG and ROUND scalar functions with two arguments #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat: Support planning LOG and ROUND scalar functions with two arguments #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
333e8de
feat: Support planning `LOG(numeric, numeric)`
MazterQyou Jan 26, 2024
2035cf4
feat: Support planning `ROUND(numeric, int)`
MazterQyou Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions datafusion/core/src/physical_plan/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,27 @@ fn signature(fun: &BuiltinScalarFunction) -> Signature {
),
BuiltinScalarFunction::Pi => Signature::exact(vec![], fun.volatility()),
BuiltinScalarFunction::Random => Signature::exact(vec![], fun.volatility()),
BuiltinScalarFunction::Log => Signature::one_of(
vec![
TypeSignature::Exact(vec![DataType::Float64]),
TypeSignature::Exact(vec![DataType::Float32]),
// NOTE: stub, won't execute
TypeSignature::Exact(vec![
DataType::Decimal(38, 10),
DataType::Decimal(38, 10),
]),
],
fun.volatility(),
),
BuiltinScalarFunction::Round => Signature::one_of(
vec![
TypeSignature::Exact(vec![DataType::Float64]),
TypeSignature::Exact(vec![DataType::Float32]),
// NOTE: stub, won't execute
TypeSignature::Exact(vec![DataType::Decimal(38, 10), DataType::Int32]),
],
fun.volatility(),
),
// math expressions expect 1 argument of type f64 or f32
// priority is given to f64 because e.g. `sqrt(1i32)` is in IR (real numbers) and thus we
// return the best approximation for it (in f64).
Expand Down