Skip to content

Implement Notifications #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 16, 2022
Merged

Implement Notifications #20

merged 14 commits into from
Nov 16, 2022

Conversation

BenHarris4848
Copy link
Contributor

Overview

Implement Notifications

Changes Made

  • Implement notifications for followed publications
  • Added permission requests for api 33+

Test Coverage

  • Manually testing across several api levels

Next Steps

  • Weekly Debrief notifications

Screenshots & Videos

Notification

20221116_124144

BenHarris4848 and others added 14 commits October 26, 2022 17:46
@BenHarris4848
Enable notifications and add log statements
6119e0b
@BenHarris4848
Merge branch 'main' of https://github.com/cuappdev/volume-android-arc…
1cd92bb 
…h-revamp into ben/notifications
@BenHarris4848
Merge branch 'main' of https://github.com/cuappdev/volume-android-arc…
226bdbc 
…h-revamp into ben/notifications
@ckdesir
Change notifications to strictly be data notifications
d0feda1
@ckdesir
Add transitions to OPEN_MAGAZINE
f727685
@ckdesir
Delete pendingIntent.send()
b968fef
@ckdesir
Change from "Saved" to "Bookmarks"
9b7da53
@ckdesir
Merge branch 'main' into ben/notifications
77bbfb8 
# Conflicts:
#	app/src/main/java/com/cornellappdev/volume/ui/screens/HomeScreen.kt
@ckdesir
Finalize Notifications and formatting
e6d79e1
@ckdesir
Delete Log
c772fc8
@ckdesir
Remove comment
230878d
@ckdesir
Add notification support for Android 13+
4442674
@ckdesir
Remove Log
6ca4628
@ckdesir
Add Notification support for API 33
32db9ed
ckdesir
ckdesir approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@ckdesir ckdesir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@BenHarris4848 BenHarris4848 merged commit d7a81cb into main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckdesir ckdesir ckdesir approved these changes

@Archit404Error Archit404Error Awaiting requested review from Archit404Error

@emilyhu8 emilyhu8 Awaiting requested review from emilyhu8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenHarris4848 @ckdesir