new action tags: add hover functionality for field notes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbembersimeao
suggested changes
Sep 6, 2017
includes/helper.php
Outdated
| return false; | ||
| } | ||
|
|
||
| function get_action_tags() { |
Contributor
There was a problem hiding this comment.
Let's keep the pattern auto_populate_fields_ in order to avoid generic names that may cause conflicts with core and/or future modules.
Let's also add a description header for this function.
ExternalModule.php
Outdated
|
|
||
| // if features are present then hover field note. | ||
| if (!empty($features)) { | ||
| $js_vars['hover_field_note'] = getFieldsWithActionTags(); |
Contributor
There was a problem hiding this comment.
The idea is to create another action tag (something like: @FIELD-NOTES-DISPLAY="hover").
… appending hook name before each function
Contributor
Author
|
made the necessary changes. |
Contributor
Author
|
@tbembersimeao made the changes that you suggested. |
suryaprasanna
changed the title
tbembersimeao
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.