Skip to content

Export noPlaceholders global variable in react-sizeme.d.ts #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

jwoe
Copy link
Contributor

@jwoe jwoe commented Oct 15, 2019

Thanks for your work providing this component! I am using it successfully in a TypeScript project.

For testing purposes, we disable the placeholder mechanism as described in https://github.com/ctrlplusb/react-sizeme#server-side-rendering in our jest setupTests.ts file. As the global variable is not defined in react-sizeme.d.ts, the TypeScript compiler complains and we temporarily silenced it by adding // @ts-ignore. This PR should fix this issue for good and allow us to remove the ts-ignore.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files           4        4           
  Lines         106      106           
  Branches       25       25           
=======================================
  Hits           96       96           
  Misses          9        9           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46b12e...afdc50e. Read the comment docs.

@ctrlplusb
Copy link
Owner

Thanks for this @jwoe, and I'm happy to hear you've been having good experiences with it. :)

@ctrlplusb ctrlplusb merged commit 6f89efd into ctrlplusb:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants