Skip to content

chore: change otel deployment to daemonset #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

chore: change otel deployment to daemonset #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3ba26e
chore: change otel deployment to daemonset
adityachoudhari26 Nov 18, 2025
ce1628f
bump chart version
adityachoudhari26 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/ctrlplane/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: ctrlplane
description: Ctrlplane Helm chart for Kubernetes
type: application
version: 0.7.1
version: 0.8.0
appVersion: "1.0.0"

maintainers:
Expand Down
11 changes: 5 additions & 6 deletions ...ane/charts/otel/templates/deployment.yaml → ...lane/charts/otel/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
apiVersion: apps/v1
kind: Deployment
kind: DaemonSet
metadata:
name: {{ include "otel.fullname" . }}
labels:
{{- include "otel.labels" . | nindent 4 }}
{{- if .Values.deployment.labels -}}
{{- toYaml .Values.deployment.labels | nindent 4 }}
{{- if .Values.daemonset.labels -}}
{{- toYaml .Values.daemonset.labels | nindent 4 }}
{{- end }}
annotations:
{{- if .Values.deployment.annotations -}}
{{- toYaml .Values.deployment.annotations | nindent 4 }}
{{- if .Values.daemonset.annotations -}}
{{- toYaml .Values.daemonset.annotations | nindent 4 }}
{{- end }}
spec:
replicas: 1
selector:
matchLabels:
{{- include "ctrlplane.selectorLabels" $ | nindent 6 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/ctrlplane/charts/otel/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ common:
labels: {}
annotations: {}

deployment:
daemonset:
labels: {}
annotations: {}

Expand Down