Rollilng Release Updates for RLC Transformation #37
Conversation
Going forward we need to run the FIPS check for every single update rather than just the "fips" ones as they will be integrated into the main rolling releases.
PlaidCat
requested review from
bmastbergen,
Copilot,
kerneltoast,
roxanan1996 and
shreeya-patel98
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the logging output of the rolling release update script to make it cleaner and more concise. The changes add a DEBUG flag that controls verbose output, consolidate logging messages, and improve message formatting with consistent prefixes and better readability.
- Added DEBUG-gated verbose logging to reduce output noise during normal execution
- Removed FIPS check conditional that was checking product name, making FIPS checks apply to all products
- Improved error messages and progress indicators with better formatting and consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rolling-release-update has had extremely verbose output and it needs to be reduced or moved into debug options. This is the first pass at that change.
PlaidCat
force-pushed
the
{jmaple}_rlc_transformation
branch
from
236150a to
d4450d2
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Print summary instead of all tags | ||
| if len(tags) > 0: | ||
| print(f'[rolling release update] Found {len(tags)} RESF kernel tags') | ||
| if DEBUG: |
There was a problem hiding this comment.
we can use logging.debug or some in house decorator logic to reduce this in the future.
There was a problem hiding this comment.
Absolutely ... one of those things that is on the list but is in the 80%+ deliverable.
Eventually we will be having all FIPS changes in our Rolling Release branches as certification is only done on a fixed version. But we also need to take into account any change that happens in crypto related paths so we know if the crypto math is ever touched and account for near by changes.
In addition the original output was excessively verbose so we've moved some of the output to a debug option.
There will be more changes coming.
Example of new output and processing can be seen here:
ctrliq/kernel-src-tree#651
Most of the rework was done with
Claude Code