Repository navigation
build: stop declaring @babel/plugin-syntax-jsx directly - #828
Merged
Merged
Conversation
cigamit
previously approved these changes
Sep 7, 2026
cigamit
added
the
Needs triage
Nothing here references it. The babel configuration lives inline in webpack.config.js and names @babel/preset-env, @babel/preset-react, @babel/plugin-transform-runtime and the local jsx-compat-plugin. JSX syntax support arrives with preset-react rather than from a plugin listed here. It is a regular dependency of @babel/plugin-transform-react-jsx, babel-plugin-styled-components and jest-snapshot, so this changes package.json only: the package stays in node_modules at 8.0.1 and the install is identical. Verified with a production build rather than lint, since the whole UI is JSX and a syntax plugin that mattered would fail compilation outright.
blaipr
force-pushed
the
build/drop-babel-plugin-syntax-jsx
branch
from
September 7, 2026 06:42
2de13c0 to
63fec15
Compare
cigamit
removed
the
Needs triage
cigamit
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Nothing here references
@babel/plugin-syntax-jsx. The babel configuration lives inline inwebpack.config.jsand names@babel/preset-env,@babel/preset-react,@babel/plugin-transform-runtimeand the localjsx-compat-plugin. JSX syntax support arrives withpreset-react, not from a plugin listed here.It is a regular dependency of
@babel/plugin-transform-react-jsx,babel-plugin-styled-componentsandjest-snapshot, so this changespackage.jsononly: the package stays innode_modulesat 8.0.1 and the install is identical.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Verified with a production build rather than lint. The whole UI is JSX, so a syntax plugin that actually mattered would fail compilation outright rather than subtly:
npm run build: succeeds.make ui-lint: clean.make ui-test-general: 1038 tests, all passing.make ui-test-screens: 1941 tests, all passing.