-
Notifications
You must be signed in to change notification settings - Fork 6
UI-1017 feat: adjust styles #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jvciq
wants to merge
5
commits into
main
Choose a base branch
from
feat/adjust-styles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,747
−1,221
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,7 @@ | ||
| engine-strict = true | ||
| @ctrliq:registry=https://npm.pkg.github.com | ||
| # - generate a new GitHub token (classic) with the read:packages scope (https://github.com/settings/tokens/new) | ||
| # - copy the token and set it as an environment variable in your shell | ||
| # export NPM_TOKEN=ghp_your_token_here | ||
| # (you can also add it to your ~/.bashrc, ~/.zshrc, etc. if you want it to be persistent) | ||
| //npm.pkg.github.com/:_authToken=${NPM_TOKEN} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| 'use strict'; | ||
|
|
||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const evalSourceMapMiddleware = require('react-dev-utils/evalSourceMapMiddleware'); | ||
| const noopServiceWorkerMiddleware = require('react-dev-utils/noopServiceWorkerMiddleware'); | ||
| const ignoredFiles = require('react-dev-utils/ignoredFiles'); | ||
|
|
@@ -43,32 +44,39 @@ module.exports = function (proxy, allowedHost) { | |
| }, | ||
| // Enable gzip compression of generated files. | ||
| compress: true, | ||
| static: { | ||
| // By default WebpackDevServer serves physical files from current directory | ||
| // in addition to all the virtual build products that it serves from memory. | ||
| // This is confusing because those files won’t automatically be available in | ||
| // production build folder unless we copy them. However, copying the whole | ||
| // project directory is dangerous because we may expose sensitive files. | ||
| // Instead, we establish a convention that only files in `public` directory | ||
| // get served. Our build script will copy `public` into the `build` folder. | ||
| // In `index.html`, you can get URL of `public` folder with %PUBLIC_URL%: | ||
| // <link rel="icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| // In JavaScript code, you can access it with `process.env.PUBLIC_URL`. | ||
| // Note that we only recommend to use `public` folder as an escape hatch | ||
| // for files like `favicon.ico`, `manifest.json`, and libraries that are | ||
| // for some reason broken when imported through webpack. If you just want to | ||
| // use an image, put it in `src` and `import` it from JavaScript instead. | ||
| directory: paths.appPublic, | ||
| publicPath: [paths.publicUrlOrPath], | ||
| // By default files from `contentBase` will not trigger a page reload. | ||
| watch: { | ||
| // Reportedly, this avoids CPU overload on some systems. | ||
| // https://github.com/facebook/create-react-app/issues/293 | ||
| // src/node_modules is not ignored to support absolute imports | ||
| // https://github.com/facebook/create-react-app/issues/1065 | ||
| ignored: ignoredFiles(paths.appSrc), | ||
| static: [ | ||
| { | ||
| // By default WebpackDevServer serves physical files from current directory | ||
| // in addition to all the virtual build products that it serves from memory. | ||
| // This is confusing because those files won't automatically be available in | ||
| // production build folder unless we copy them. However, copying the whole | ||
| // project directory is dangerous because we may expose sensitive files. | ||
| // Instead, we establish a convention that only files in `public` directory | ||
| // get served. Our build script will copy `public` into the `build` folder. | ||
| // In `index.html`, you can get URL of `public` folder with %PUBLIC_URL%: | ||
| // <link rel="icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| // In JavaScript code, you can access it with `process.env.PUBLIC_URL`. | ||
| // Note that we only recommend to use `public` folder as an escape hatch | ||
| // for files like `favicon.ico`, `manifest.json`, and libraries that are | ||
| // for some reason broken when imported through webpack. If you just want to | ||
| // use an image, put it in `src` and `import` it from JavaScript instead. | ||
| directory: paths.appPublic, | ||
| publicPath: [paths.publicUrlOrPath], | ||
| // By default files from `contentBase` will not trigger a page reload. | ||
| watch: { | ||
| // Reportedly, this avoids CPU overload on some systems. | ||
| // https://github.com/facebook/create-react-app/issues/293 | ||
| // src/node_modules is not ignored to support absolute imports | ||
| // https://github.com/facebook/create-react-app/issues/1065 | ||
| ignored: ignoredFiles(paths.appSrc), | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| // Serve quantic-fonts assets at /assets path | ||
| directory: path.resolve(__dirname, '../node_modules/@ctrliq/quantic-fonts/dist/assets'), | ||
| publicPath: '/assets', | ||
| }, | ||
| ], | ||
| client: { | ||
| webSocketURL: { | ||
| // Enable custom sockjs pathname for websocket connection to hot reloading server. | ||
|
|
@@ -92,14 +100,19 @@ module.exports = function (proxy, allowedHost) { | |
| }, | ||
| server: { | ||
| type: 'https', // Specify the server type as 'https' | ||
| ...getHttpsConfig() | ||
| ...getHttpsConfig(), | ||
| }, | ||
| host, | ||
| historyApiFallback: { | ||
| // Paths with dots should still use the history fallback. | ||
| // See https://github.com/facebook/create-react-app/issues/387. | ||
| disableDotRule: true, | ||
| disableDotRule: false, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: What does this do? |
||
| index: paths.publicUrlOrPath, | ||
| rewrites: [ | ||
| // Exclude static assets from fallback to allow webpack to serve them | ||
| { from: /\.(woff|woff2|ttf|eot|otf)$/, to: (context) => context.parsedUrl.pathname }, | ||
| { from: /\.(css|js|json|ico|png|jpg|jpeg|gif|svg)$/, to: (context) => context.parsedUrl.pathname }, | ||
| ], | ||
| }, | ||
| // `proxy` is run between `before` and `after` `webpack-dev-server` hooks | ||
| proxy, | ||
|
|
@@ -114,6 +127,13 @@ module.exports = function (proxy, allowedHost) { | |
| require(paths.proxySetup)(devServer.app); | ||
| } | ||
|
|
||
| devServer.app.use((req, res, next) => { | ||
| if (/\.(woff2)(\?|$)/i.test(req.url)) { | ||
| res.setHeader('Content-Type', 'font/woff2'); | ||
| } | ||
| next(); | ||
| }); | ||
|
|
||
| // Redirect to `PUBLIC_URL` or `homepage` from `package.json` if url not match | ||
| devServer.app.use(redirectServedPath(paths.publicUrlOrPath)); | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Could this conflict with an actual public assets folder?
Should we/Could we make it a more specific path like
quantic-assets?