Repository navigation
Conversation
construct_rsyslog_conf_template() emitted queue.discardSeverity="5" as a literal. Job events and activity stream entries are logged at INFO, so once LOG_AGGREGATOR_LEVEL lets them through and the action queue reaches queue.discardMark, all of them are eligible to be dropped, silently, and no setting could change that. Register LOG_AGGREGATOR_ACTION_QUEUE_DISCARD_SEVERITY (0-8, default 5) and emit it in place of the literal. The default is what Ascender emits today, so existing configurations render byte-identically and the durability test's "least important first" promise still holds; 8 disables discarding, at the cost of blocking the sender for queue.timeoutEnqueue when the queue is genuinely full. related ctrliq#1095 Assisted-by: Claude Opus 5.5 Signed-off-by: Quanah Gibson-Mount <quanah@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Assisted-by: Claude Opus 5.5. Drafted with AI assistance; the commit carries the same trailer.
construct_rsyslog_conf_template()emitsqueue.discardSeverity="5"as a literal. Job events and activity stream entries are logged at INFO, so onceLOG_AGGREGATOR_LEVELlets them through and the action queue reachesqueue.discardMark, all of them can be dropped, silently, and no setting can change that.Register
LOG_AGGREGATOR_ACTION_QUEUE_DISCARD_SEVERITY(0–8, default 5) and emit it in place of the literal. The default is what Ascender emits today, so existing configurations render byte-identically andtest_what_is_discarded_is_the_least_importantstill holds; 8 disables discarding, at the cost of blocking the sender forqueue.timeoutEnqueuewhen the queue is genuinely full. The setting is also added to the durability test's list of user-visible settings that must reach the queue.Same change as ansible/awx#16714, ported to Ascender's generator.
related #1095
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
ADDITIONAL INFORMATION
Tests:
test_rsyslog_conf_discard_severityinascender/main/tests/unit/api/test_logger.py, parametrized over the registered default (which must still render5), 8 and 0; plus one entry intest_the_settings_users_can_set_reach_the_queue(test_external_logging_durability.py), which records the setting as a promise and passes onmaintoo. Run inpython:3.14with Ascender's requirements, as an unprivileged user:ruff checkandruff format --check(ruff 0.16.6, as pinned intox.ini) are clean on the touched files.