Update to 1.86 and update OSX backend (fix keyboard issue) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi Christian, thank you for wrapping ImGui in Swift! I am actually using the package in my personal project. Really enjoy it.
This PR is update the version to v1.86. In the version v1.82, I was not able to fix the keyboard issue, so I decided to wrap the latest commit from cimgui and then update the backend files accordingly.
Next step, I plan to update docking branch as well. Would be nice to have it documented in
HOWTO.mdas well.Please let me know if you find formatting issues or somewhere you think can be improved. I am new to Swift. Glad to read your code and learn! Thank you.
Detailed Design
1st Commit - Update to 1.86 and update README/HOWTO
After running
make updateI made these updates to resolve warnings/errors:patch_fix_ifdefs.diffto resolve errorsExceptions.swiftto exclude new unresolved identifiersescapingCallbackExceptionsinArgT.swiftto avoid adding@escapingto the typeImGuiErrorLogCallbackwhich is actually not a callback functionFunctionBodyRenderer.swiftto suppress warning (dangling pointer) when generatingUnsafeMutableBufferPointer. It is needed since after update there is a new usage using this type.Documentation Updates:
README.mdandHOWTO.md. I think it would be great to include steps about how to wrap more functions.2nd Commit - Update backend (1.86) to support keyboard/gamepad/clipboard events
I basically followed imgui_impl_osx.mm in imgui 1.86.
ImGui_ImplOSX_Initnow hasNSViewas parameterI played around with the demo and I didn't find any issue yet.
Documentation
I updated the
README.mdandHOWTO.mdto include more details.Documentation and comments from the original Obj-C backend file are kept.
Testing
For wrapping: No errors after
make update.For backends: I tested keyboard/mouse/gamepad/clipboard. All work as expected.
Performance
N/A
Source Impact
No.
Checklist