Skip to content

Refactor test cases of AnnotateRoutes - completed version #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drwl merged 19 commits into from
Feb 25, 2020
Merged

Refactor test cases of AnnotateRoutes - completed version #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e2c79e0
Unify describe clauses with magic comments
nard-tech Feb 2, 2020
c80d3ea
Make purpose of test cases more clear using describe and rewrite cont…
nard-tech Feb 2, 2020
93121f0
Define variables using let
nard-tech Feb 2, 2020
e6f69d4
Refactor by before(:each)
nard-tech Feb 2, 2020
01db725
Make purpose of test cases more clear using describe and rewrite cont…
nard-tech Feb 2, 2020
3142d5e
Define variables using let
nard-tech Feb 2, 2020
3b3b061
Write precondition of result of `rake routes` in `before(:each)`
nard-tech Feb 2, 2020
5758c75
Write test cases of message in 'it' block
nard-tech Feb 2, 2020
3d89a4e
Remove an empty line
nard-tech Feb 2, 2020
d6ba9a1
Write test cases for file content in 'it' block
nard-tech Feb 2, 2020
b064f1e
Write precondition of result of reading file in `before(:each)`
nard-tech Feb 2, 2020
4dd53de
Specify number of times of executions
nard-tech Feb 2, 2020
702830e
Add test cases for confirming that the file is not opened and file do…
nard-tech Feb 2, 2020
b3e14d9
Fix test cases when the file contains magic comments
nard-tech Feb 3, 2020
65b201b
Make purpose of test cases more clear
nard-tech Feb 2, 2020
f5cff71
Refactor test cases when the result of `rake routes` is blank
nard-tech Feb 3, 2020
6de2d6e
Make purpose of test cases more clear
nard-tech Feb 3, 2020
dfdffc5
Refactor test cases when the result of `rake routes` contains Rake ve…
nard-tech Feb 3, 2020
627f092
Execute `rubocop --auto-gen-config`
nard-tech Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2020-02-13 18:10:52 +0900 using RuboCop version 0.68.1.
# on 2020-02-13 20:05:34 +0900 using RuboCop version 0.68.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -64,14 +64,6 @@ Layout/ExtraSpacing:
- 'lib/annotate/annotate_models.rb'
- 'lib/tasks/annotate_routes.rake'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver
Layout/MultilineMethodCallIndentation:
Exclude:
- 'spec/lib/annotate/annotate_routes_spec.rb'

# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth.
Expand Down Expand Up @@ -221,7 +213,7 @@ Naming/AccessorMethodName:
Exclude:
- 'lib/annotate.rb'

# Offense count: 93
# Offense count: 103
# Configuration parameters: Blacklist.
# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
Naming/HeredocDelimiterNaming:
Expand Down Expand Up @@ -478,7 +470,7 @@ Style/StderrPuts:
- 'lib/annotate.rb'
- 'lib/annotate/annotate_models.rb'

# Offense count: 111
# Offense count: 107
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Expand All @@ -490,7 +482,6 @@ Style/StringLiterals:
- 'lib/tasks/annotate_models_migrate.rake'
- 'lib/tasks/annotate_routes.rake'
- 'spec/lib/annotate/annotate_models_spec.rb'
- 'spec/lib/annotate/annotate_routes_spec.rb'
- 'spec/lib/annotate/parser_spec.rb'

# Offense count: 1
Expand Down Expand Up @@ -528,7 +519,7 @@ Style/UnneededPercentQ:
Exclude:
- 'annotate.gemspec'

# Offense count: 346
# Offense count: 377
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Expand Down
Loading