Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Added error handling in MXNet #19

Open
wants to merge 47 commits into
base: mxnet_feature_fp16
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
d625394
Make mxnet build successful in CPU
apeforest Nov 30, 2018
02ab771
update required mxnet version
apeforest Dec 3, 2018
9abcc4e
remove outdated comment
apeforest Dec 3, 2018
cd096e4
remove commented line
apeforest Dec 3, 2018
f9b2083
Merge remote-tracking branch 'origin/mxnet_feature_fp16' into develop…
apeforest Dec 3, 2018
b0e2e58
fix test in CPU
apeforest Dec 4, 2018
dd4f9e2
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Dec 4, 2018
b617e14
refactor
apeforest Dec 4, 2018
84ed58e
Merge branch 'mxnet_feature_fp16' into develop/mxnet
yuxihu Dec 4, 2018
2b902ae
link nccl to mpi_lib for mxnet
yuxihu Dec 4, 2018
ff57e51
Merge branch 'develop/mxnet' of https://github.com/ctcyang/horovod in…
apeforest Dec 4, 2018
6013957
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Dec 4, 2018
bc47aa9
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Dec 19, 2018
297e79a
make mxnet build process the same as tensorflow
apeforest Dec 19, 2018
f28ba01
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Dec 28, 2018
ab78201
compute allreduce average in C++ to avoid perf deg
apeforest Dec 28, 2018
dc62625
rename variable
apeforest Dec 28, 2018
c56322f
add mxnet mnist example
apeforest Jan 1, 2019
4eb787e
fix lint
apeforest Jan 1, 2019
3e5491a
reduce epoch and acc check
apeforest Jan 2, 2019
9589209
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 2, 2019
b42f0c5
broadcast initial parames
apeforest Jan 2, 2019
13adbb3
Update README
apeforest Jan 2, 2019
b4aa9f2
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 3, 2019
f9c9d73
remove unused handle manager
apeforest Jan 3, 2019
dc96acc
renaming variable type
apeforest Jan 3, 2019
aaf3d7f
return non empty op name
apeforest Jan 4, 2019
0797570
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 4, 2019
89ba103
scale learning rate by workers
apeforest Jan 4, 2019
60877b7
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 4, 2019
b3a24db
refactor test_mxnet to make it easier to read
apeforest Jan 5, 2019
6e4b845
fix a bug in building on GPU
apeforest Jan 5, 2019
710c703
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 5, 2019
0112e6a
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 5, 2019
4a1c010
polish imagenet example
apeforest Jan 6, 2019
61741e8
add handle_manager
apeforest Jan 6, 2019
c24d0bd
error handling in MXNet
apeforest Jan 7, 2019
effd043
Merge branch 'mxnet_feature_fp16' into develop/mxnet
apeforest Jan 7, 2019
1c9443f
add exception handling
apeforest Jan 8, 2019
9b9bab1
rename c_api_common
apeforest Jan 8, 2019
2d64e05
wrap MXNet C API with exception handling
apeforest Jan 8, 2019
1cd08be
remove unused function declaration
apeforest Jan 9, 2019
77cbb8b
fix a typo
apeforest Jan 9, 2019
4f1a626
fix a bug
apeforest Jan 9, 2019
c1c476c
fix build error
apeforest Jan 9, 2019
51f81d0
Merge branch 'mxnet_feature_fp16' into develop/mxnet
Jan 14, 2019
75c56f7
Merge remote-tracking branch 'origin/mxnet_feature_fp16' into develop…
Jan 14, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
return non empty op name
  • Loading branch information
apeforest committed Jan 4, 2019
commit aaf3d7f30df735927056e44050418b727908d6ca
7 changes: 6 additions & 1 deletion horovod/mxnet/mpi_ops.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@ namespace horovod {
namespace mxnet {

namespace {

std::atomic_int op_count;

std::string GetOpName(std::string prefix, char* name) {
if (name != nullptr) {
return prefix + "." + std::string(name);
}
return std::string();

op_count.fetch_add(1);
return prefix + ".noname." + std::to_string(op_count);
}
} // namespace

Expand Down