Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_valid flag to output file. #46

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Conversation

aleberti
Copy link
Collaborator

No description provided.

@aleberti aleberti requested a review from YoshikiOhtani April 26, 2022 19:49
@YoshikiOhtani
Copy link
Collaborator

Thanks @aleberti, I will merge this pull request now.

@YoshikiOhtani YoshikiOhtani merged commit bf2b4f9 into master Apr 27, 2022
@YoshikiOhtani YoshikiOhtani deleted the save-is-valid-flag branch April 27, 2022 03:49
@jsitarek
Copy link
Collaborator

Hi @aleberti
with this added is_valid field the script does not save the output anymore for me:
File "lst1_magic_stereo_reco.py", line 323, in
main()
File "lst1_magic_stereo_reco.py", line 314, in main
stereo_reconstruction(args.input_file, args.output_dir, config)
File "lst1_magic_stereo_reco.py", line 275, in stereo_reconstruction
save_pandas_to_table(event_data, output_file, group_name='/events', table_name='parameters', mode='w')
File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/magicctapipe/utils/functions.py", line 307, in save_pandas_to_table
f_out.create_table(group_name, table_name, createparents=True, obj=event_table)
File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/tables/file.py", line 1040, in create_table
descr, _ = descr_from_dtype(obj.dtype, ptparams=self.params)
File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/tables/description.py", line 865, in descr_from_dtype
"are not supported yet, sorry" % dtype)
NotImplementedError: structured arrays with columns with type description object are not supported yet, sorry

@aleberti
Copy link
Collaborator Author

Hi @aleberti with this added is_valid field the script does not save the output anymore for me: File "lst1_magic_stereo_reco.py", line 323, in main() File "lst1_magic_stereo_reco.py", line 314, in main stereo_reconstruction(args.input_file, args.output_dir, config) File "lst1_magic_stereo_reco.py", line 275, in stereo_reconstruction save_pandas_to_table(event_data, output_file, group_name='/events', table_name='parameters', mode='w') File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/magicctapipe/utils/functions.py", line 307, in save_pandas_to_table f_out.create_table(group_name, table_name, createparents=True, obj=event_table) File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/tables/file.py", line 1040, in create_table descr, _ = descr_from_dtype(obj.dtype, ptparams=self.params) File "/home/jsitarek/anaconda3/envs/magic-lst1/lib/python3.7/site-packages/tables/description.py", line 865, in descr_from_dtype "are not supported yet, sorry" % dtype) NotImplementedError: structured arrays with columns with type description object are not supported yet, sorry

I just merged a PR into master that should solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants