Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra dec db #259

Merged
merged 4 commits into from
Sep 19, 2024
Merged

ra dec db #259

merged 4 commits into from
Sep 19, 2024

Conversation

Elisa-Visentin
Copy link
Collaborator

Now it is 'safe'. I will list comments/requests from the old PR below

@Elisa-Visentin
Copy link
Collaborator Author

Elisa-Visentin commented Sep 12, 2024

  • options changed to -s (doc string)
  • lines to set ra, dec, mc dec repeated in try except
  • read ra and dec together from dictionary: it depends on if there are some sources for which only one coordinate is known. But I would ay that after the last dict updates this is no more the case (I will check)
  • one extended source in db and one 'not source'
  • sort dictionary: now alphabetically

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (f4b775e) to head (5c2e324).
Report is 16 commits behind head on auto_MCP_DL2_DL3.

Additional details and impacted files
@@                Coverage Diff                @@
##           auto_MCP_DL2_DL3     #259   +/-   ##
=================================================
  Coverage             77.23%   77.23%           
=================================================
  Files                    21       21           
  Lines                  2614     2614           
=================================================
  Hits                   2019     2019           
  Misses                  595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsitarek jsitarek merged commit dcc0898 into auto_MCP_DL2_DL3 Sep 19, 2024
8 checks passed
@jsitarek jsitarek deleted the db_ra_dec branch September 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants