Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to apply cloud affection correction to the LST, Magic 1, and M… #241

Merged
merged 15 commits into from
Sep 11, 2024

Conversation

nzywucka
Copy link
Collaborator

@nzywucka nzywucka commented Aug 7, 2024

…agic 2 data

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (01f273d) to head (ca78fb3).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   77.23%   77.23%           
=======================================
  Files          21       21           
  Lines        2614     2614           
=======================================
  Hits         2019     2019           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleberti aleberti added the new functionality For new functionalities label Sep 3, 2024
@jsitarek jsitarek marked this pull request as ready for review September 4, 2024 08:22
@nzywucka
Copy link
Collaborator Author

Hi @nzywucka can you post the .keys() from the /events/parameters from original DL1 file (not the DL1stereo!) and from this new file that you create?

Both files gives the same list of parameters, namely:

Index(['obs_id', 'event_id', 'tel_id', 'obs_id_magic', 'event_id_magic',
'obs_id_lst', 'event_id_lst', 'intensity', 'x', 'y', 'r', 'phi',
'length', 'length_uncertainty', 'width', 'width_uncertainty', 'psi',
'skewness', 'kurtosis', 'slope', 'intercept', 'intensity_width_1',
'intensity_width_2', 'pixels_width_1', 'pixels_width_2', 'n_pixels',
'concentration_cog', 'concentration_core', 'concentration_pixel',
'n_islands', 'pointing_alt', 'pointing_az', 'timestamp', 'time_diff',
'multiplicity', 'combo_type'],
dtype='object')

also please check that all the parameters have exactly the same values if T=1 is taken

Distributions of parameters looks the same from the original file (blue) and corrected (orange):

params_comp

@jsitarek jsitarek merged commit 0b40daf into master Sep 11, 2024
8 checks passed
@jsitarek jsitarek deleted the correction branch September 11, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new functionality For new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants