Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto mcp errors coin #221

Merged
merged 6 commits into from
May 16, 2024
Merged

Auto mcp errors coin #221

merged 6 commits into from
May 16, 2024

Conversation

jsitarek
Copy link
Collaborator

refactoring of merging_runs to unify the code for NSB_match yes/no
with some change of behaviour (the files to be run over are read from .txt files but the script is checking if the directories with the data exist)

@jsitarek jsitarek marked this pull request as draft May 15, 2024 15:06
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (a21a155) to head (c829703).
Report is 3 commits behind head on Torino_auto_MCP.

❗ Current head c829703 differs from pull request most recent head 2111e95. Consider uploading reports for the commit 2111e95 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           Torino_auto_MCP     #221   +/-   ##
================================================
  Coverage            77.15%   77.15%           
================================================
  Files                   21       21           
  Lines                 2591     2591           
================================================
  Hits                  1999     1999           
  Misses                 592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Elisa-Visentin
Copy link
Collaborator

Seems to be fine

jsitarek added 2 commits May 16, 2024 10:10
also some refactoring in the setting up, mergi  and coincidence scripts
@jsitarek jsitarek marked this pull request as ready for review May 16, 2024 12:34
@jsitarek jsitarek requested a review from Elisa-Visentin May 16, 2024 12:34
it works even if some files were produced with the same job
@jsitarek jsitarek merged commit 584b632 into Torino_auto_MCP May 16, 2024
3 of 4 checks passed
@jsitarek jsitarek deleted the auto_MCP_errors_coin branch May 16, 2024 17:18
@aleberti aleberti added the refactoring For code refactoring label Aug 7, 2024
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
error tracking in merging in automatic MCP processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring For code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants