Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coincident event search using large shower events #143

Merged
merged 13 commits into from
Jun 25, 2023

Conversation

SeiyaNozaki
Copy link
Collaborator

Since the time offset depends on the observation dates, we needed to tune the offset scan region if we use the current method. This PR adds an option (all_combination) to select the best time offset among all possible combinations using large shower events. For the moment, 50 (MAGIC) x 50 (LST) events are selected by default to compute all possible time offsets and count coincident events with an assumed offset.

@SeiyaNozaki SeiyaNozaki marked this pull request as draft May 16, 2023 21:39
@SeiyaNozaki
Copy link
Collaborator Author

SeiyaNozaki commented May 21, 2023

The updated procedure is

  • Pre offset search
  1. Large-intensity events (100 LST x 100 MAGIC) are extracted
  2. Compute all possible time offsets
  3. Find the best offset giving the largest numbers of coincident events
  4. Define +/- full window width (600 ns) around the best offset as the offset scan region
  • Time offset scan using this offset and full datasets
    Since offset scan region can be different between M1 and M2, profile data frame is like below:
    Screenshot from 2023-05-22 00-07-25

Since the final coincident event search is performed using full datasets, the same coincident events are extracted w/ or w/o this method. The only weak point is that it does not work if the number of coincident events is too low (<10 events), but I think it is negligible.

@SeiyaNozaki SeiyaNozaki marked this pull request as ready for review May 21, 2023 22:36
Copy link
Collaborator

@aleberti aleberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Seiya for the implementation! I left some comments for your attention. One thing: did you try to see as x-check if you get similar/same results if you use the "all combination" approach and the old one with a time offset equal to the one found in the new method? Looking at the code it should, but since it should be a quick check, if you can do it, it would be great!

@SeiyaNozaki
Copy link
Collaborator Author

Thank you Alessio for the comments!

One thing: did you try to see as x-check if you get similar/same results if you use the "all combination" approach and the old one with a time offset equal to the one found in the new method?

Yes! Here you can also see the difference in the results between the current method and the updated one ('all combination' approach) using 2962 LST subrun data taken in March 2023.
image

@SeiyaNozaki
Copy link
Collaborator Author

Following the comment by @YoshikiOhtani in the meeting, I changed the scan range to +/-3 x half_window_width (1.5 x full window width) around the offset the pre-search found. Using this offset scan range, I got completely the same results (time offset, n_coincidence_events) as the current method for all of LST subruns.

@YoshikiOhtani
Copy link
Collaborator

YoshikiOhtani commented Jun 1, 2023

Thank you very much @SeiyaNozaki for this implementation! Even though I did not check the code in detail, I can already approve this pull request, based on the presentation in the meeting. So if we resolve all the comments by @aleberti (and no more comments from @jsitarek), I think we can merge this.

@aleberti aleberti merged commit 725ce6f into master Jun 25, 2023
@aleberti aleberti deleted the update_coincident_evt_search branch August 23, 2023 13:36
@aleberti aleberti added enhancement New feature or request new functionality For new functionalities labels Nov 2, 2023
Elisa-Visentin pushed a commit that referenced this pull request Sep 12, 2024
…arch

Update coincident event search using large shower events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new functionality For new functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants