-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coincident event search using large shower events #143
Conversation
… lst1_magic_event_coincidence.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Seiya for the implementation! I left some comments for your attention. One thing: did you try to see as x-check if you get similar/same results if you use the "all combination" approach and the old one with a time offset equal to the one found in the new method? Looking at the code it should, but since it should be a quick check, if you can do it, it would be great!
magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py
Outdated
Show resolved
Hide resolved
magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py
Outdated
Show resolved
Hide resolved
…ound by pre-search
Following the comment by @YoshikiOhtani in the meeting, I changed the scan range to +/-3 x half_window_width (1.5 x full window width) around the offset the pre-search found. Using this offset scan range, I got completely the same results (time offset, n_coincidence_events) as the current method for all of LST subruns. |
Thank you very much @SeiyaNozaki for this implementation! Even though I did not check the code in detail, I can already approve this pull request, based on the presentation in the meeting. So if we resolve all the comments by @aleberti (and no more comments from @jsitarek), I think we can merge this. |
…arch Update coincident event search using large shower events
Since the time offset depends on the observation dates, we needed to tune the offset scan region if we use the current method. This PR adds an option (
all_combination
) to select the best time offset among all possible combinations using large shower events. For the moment, 50 (MAGIC) x 50 (LST) events are selected by default to compute all possible time offsets and count coincident events with an assumed offset.