DLRawTriggerReader #151
Open
DLRawTriggerReader #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use astropy for sky offset and separation calculation
Fixing Codacy's "undefined loop variable" error.
Prepping for new release
Allowing external algo to find trigger patch
Remove artifacts of the writer scripts in the README
Update README.rst
Update release.yml
…ile due permissions issues. for example: -rw-r--r-- 1 tjark.miener ctan-onsite-it 86051602 May 21 09:02 /fefs/aswg/workspace/tjark.miener/DeepCrab/logs/theta_16.087_az_108.090/LST1_cleanedTRN_type_fixcamgeo/example_identifiers_file.h5. Setting to read mode I am able to read it.
…_in_read_mode_only example_identifiers_file is not able to open due a permissions issue.
Test release
This is later needed to do the pointing interpolation with the correct time stamp also check that only a single file is provided when processing real data
jbuces
force-pushed
the
Jorge_TriggerReader
branch
from
72afd7a to
52599e2
Compare
…n different function
|
Hi @jbuces ! What is the status of this PR draft? Anything missing to convert to "ready for review", so @nietootein and me can have a look? |
|
Hi @TjarkMiener! The times for processing 50000 events with the tdscan trigger on the complete waveform (way higher for patches waveform) is of around 30 minutes. So I added to the code an option to read the tdscan mask from a precomputed h5 file. The problem of computing it on the fly would be for the training part, to visualise how TDSCAN works by creating batches with the dl1 it is more than fine. I was thinking in removing the tdscan from the PR, what do you thinnk @nietootein, @TjarkMiener? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the possibility to process r0 waveforms, and multiple forms of treating trigger patches of these raw waveforms.
Fixes #148 .
DLRawTriggerReader.pdf