guard for partial content download #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partial content download could result in some of the file being piped to shell in the case of an error currently, the if/then blocks guard the script against this, but by putting everything into a function call makes it harder to accidentially add a line outside an if/else block without realizing the impact Signed-off-by: Andrew Klotz <agc.klotz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial content download could result in some
of the file being piped to shell in the case of
an error
currently, the if/then blocks guard the script against this,
but by putting everything into a function call makes it
harder to accidentally add a line outside an
if/else block without realizing the impact
Signed-off-by: Andrew Klotz agc.klotz@gmail.com