Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I originally put the ember-cli dependencies in de Ember.js group in #372, but found out that ember-cli versions are independent of Ember.js updates and newer CLI versions can still build older Ember.js apps. This PR changes the base image in the Dockerfile to another ember-cli image which has the following pros and cons:
Pros
Dockerfile.test
redundant but the overall size is a bit bigger, the bundle size isn't though since the NGINX stage in the Dockerfile still does the sameCons
I also used digest pinning for the Docker image versions of ember-cli and NGINX.
Other information