Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Dockerfile base image #412

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Conversation

guidojw
Copy link
Member

@guidojw guidojw commented Dec 13, 2021

Summary

I originally put the ember-cli dependencies in de Ember.js group in #372, but found out that ember-cli versions are independent of Ember.js updates and newer CLI versions can still build older Ember.js apps. This PR changes the base image in the Dockerfile to another ember-cli image which has the following pros and cons:

Pros

  • It's updated more frequently
  • Its Node.js version actually matches most up-to-date ember-cli support (madnificent's (one we use now) doesn't sadly)
  • Unblocks chore(deps): update dependency eslint to v8 #399 (due to compatible Node.js version, above point)
  • It looks like this can also easily be used in a development environment (I tried in Feature/Allow to run dev server via Docker #235, did not succeed, can try again with this one as base in the future)
  • It installs Chrome drivers so makes Dockerfile.test redundant but the overall size is a bit bigger, the bundle size isn't though since the NGINX stage in the Dockerfile still does the same

Cons

  • The overall size is a bit bigger

I also used digest pinning for the Docker image versions of ember-cli and NGINX.

Other information

@guidojw
Copy link
Member Author

guidojw commented Dec 13, 2021

Tests fail because this needs #411

@guidojw guidojw merged commit dcdc08e into staging Jan 19, 2022
@guidojw guidojw deleted the feat/new-dockerfile-base-image branch January 19, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants