Skip to content

writer-json-sarif: fix miscompilation with recent Apple Clang #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

lzaoral
Copy link
Member

@lzaoral lzaoral commented Jan 31, 2024

For a reason I'm too lazy to diagnose, latest releases of Apple Clang now ignore the outermost initializer lists with object initializers which GCC still translates to an array. Construct the arrays explicitly to avoid this ambiguity.

Resolves: #160

For a reason I'm too lazy to diagnose, latest releases of Apple Clang now
ignore the outermost initializer lists with object initializers which GCC
still translates to an array.  Construct the arrays explicitly to avoid this
ambiguity.

Resolves: csutils#160
@lzaoral lzaoral requested a review from kdudka January 31, 2024 12:34
@lzaoral lzaoral self-assigned this Jan 31, 2024
Copy link
Member

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzaoral Wow, that was fast. Thanks!

@lzaoral lzaoral merged commit b9453dc into csutils:main Jan 31, 2024
@lzaoral lzaoral deleted the fix-ci-macos branch January 31, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different sarif output produced on macOS latest
2 participants