Skip to content

cslinker: do not abort on empty property in scan.ini #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2023
Merged

cslinker: do not abort on empty property in scan.ini #132

merged 2 commits into from
Jun 19, 2023

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Jun 19, 2023 

[...]
>>> 2023-06-19 10:34:00 "cslinker --quiet --cwelist '/usr/share/csmock/cwe-map.csv' --inifile '/tmp/csmocklj8jvfjs/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/scan.ini' '/t
terminate called after throwing an instance of 'boost::wrapexcept<boost::bad_lexical_cast>'
  what():  bad lexical cast: source type value could not be interpreted as target

!!! 2023-06-19 10:34:00 fatal error: caught signal 6

@kdudka kdudka requested a review from lzaoral June 19, 2023 14:19
@kdudka kdudka self-assigned this Jun 19, 2023
lzaoral
lzaoral approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdudka
Copy link
Member Author

kdudka commented Jun 19, 2023 •
edited
Loading

@lzaoral Thanks for review! We will need to release a fixed version of csdiff soon because it affects also csgrep --embed-context, which runs in mock chroot:

[...]
>>> 2023-06-19 16:28:25 "'/usr/bin/mock' '-r' 'rhel-8-rhaos-x86_64' '--plugin-option=tmpfs:keep_mounted=True' '--config-opts=print_main_output=True' '--quiet' '--shell' 'csgrep --mode=json --embed-context 3' < '/tmp/csmockilv4hciy/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/debug/scan-results-all.js' > '/tmp/csmockilv4hciy/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/debug/scan-results-all.js.tmp'"
terminate called after throwing an instance of 'boost::wrapexcept<boost::bad_lexical_cast>'
  what():  bad lexical cast: source type value could not be interpreted as target

!!! 2023-06-19 16:28:28 fatal error: caught signal 122

@kdudka
cslinker: do not abort on empty property in scan.ini
f600411 
```
[...]
>>> 2023-06-19 10:34:00 "cslinker --quiet --cwelist '/usr/share/csmock/cwe-map.csv' --inifile '/tmp/csmocklj8jvfjs/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/scan.ini' '/tmp/csmocklj8jvfjs/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/debug/uni-results'/* > '/tmp/csmocklj8jvfjs/openshift-clients-4.7.0-202103251046.p0.git.3957.c4da68b.el8/debug/scan-results-all.js'"
terminate called after throwing an instance of 'boost::wrapexcept<boost::bad_lexical_cast>'
  what():  bad lexical cast: source type value could not be interpreted as target

!!! 2023-06-19 10:34:00 fatal error: caught signal 6
```

Closes: csutils#132
@kdudka kdudka force-pushed the cslinker-empty-prop branch from 68466cf to f600411 Compare June 19, 2023 14:35
@kdudka kdudka closed this in f600411 Jun 19, 2023
@kdudka kdudka merged commit f600411 into csutils:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzaoral lzaoral lzaoral approved these changes

Assignees

@kdudka kdudka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdudka @lzaoral