RPC level 1 implementation #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: release and adquire GIL better integration (?) more testing write documentation
capabilityServer don't stops when interrupted. it need to respond to an rpcRequest in order to close. this will be fixed somehow
deleted c++ servers. from now on, all the test are runned from ruby clients to ruby servers. coding a interesting , usefull and simple sample. WIP detected a bug on the native extension binding. WIP
+todo: fix pipelines completly.
|
hello again, if you don't mind i will publish my work as a gem called "capn_proto-rpc" so the community can use it. If you like my work and merge my changes i will delete my gem and tell the community to use the main capn_proto gem instead. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I am a google summer of code 2016 student and my project was to implement an level 1 CapnProto RPC.
I used as a base your binding and then just extended it.
You did a splendid job. It was pretty easy to work with your code.
I did the RPC with simplicity in mind. I wanted to make it as easier as possible. But without losing too much power. The blocking parts of the system always run without GIL so another ruby threads can run while the RPC waits.
Is fully usable and the only known bug at the moment is that the server don't shutdown when pressing control-c. It only closes when you press control-c and then a request is made to the server.