Extend action with supporting relative path for portainer be #13
Conversation
|
This seems logical. I will check this out in my IDE later today and review the docs. You do need to run the build, and I will try to fix the test. build - you need to run |
|
Hi, I already run build and pushed the change, took me a while to firgue out this for it to work. Testing have been done in one of my repository, no issue found, but feel free to test it again on your side. By the way, I think build on push is useful, and test can be carried through simple api testing with mock. |
vanduc2514
changed the title
If the Build was run, there would be a modified After you run
Yes, sorry. I will add a CONTRIBUTING.md guide next chance I get. I am literally working on one now for all my actions!
Yea, I will create a branch to test.
I found out that I now need the TLDR: I can run and commit the build for you if you can't get it working. I wasted too much time updating another action today and may not get around to this until tomorrow. |
|
I forgot to run build again with the latest change, automatic build would be nice. I pushed new build also enabled the cleanup step in workflow for test action
Test action run successfull https://github.com/vanduc2514/portainer-stack-deploy-action/actions/runs/13353255771 |
There was a problem hiding this comment.
I requested some changes and suggested another. If you don't have time to make the changes, I can make them myself after I merge.
Again, don't worry about the test failing, I removed that as a requirement and will fix it later.
Other than that it looks solid, thank you for the contribution, and sorry for my spaghetti code and lack of contributing guides.
src/index.js
Outdated
| if (fs_path) { | ||
| // get system info and check if portainer is BE edition | ||
| const version = await portainer.getVersion() | ||
| const is_portainer_be = version.ServerEdition == 'EE' |
There was a problem hiding this comment.
While this is not an issue, it should be === and not == when comparing 2 strings.
| const is_portainer_be = version.ServerEdition == 'EE' | |
| const is_portainer_be = version.ServerEdition === 'EE' |
There was a problem hiding this comment.
When this is committed, it should re-trigger the automation without the test and give a ✔️
|
I forgot I cant disable the test, since its combined with the linter and build check. I re-enabled it; however, not sure how to kick them off, their stuck in pending, lol. Maybe make an arbitrary change in a comment somewhere. Sorry about the confusion. |
Happing to me also, for a quick second, I thought the change has something wrong :)) Anyhow, please do your best to re-enable the workflow again for me to be able to merge |
I re-enabled them. I think it will take another commit to re-trigger them. Just add or delete any text in a comment in the test.yaml. If you can't do that, I can temporarily make them not-required to merge. |
|
|
Just commented the test job, and the workflow pass run flawlessly. Let's work on that in another time :D |
No description provided.